lgtm
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352 src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes, Maybe it should be noted that data in the snapshot (if present) will supersede these flags http://codereview.chromium.org/9086006/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (left): http://codereview.chromium.org/9086006/diff/1/src/mips/code-stubs-mips.cc#oldcode5929 src/mips/code-stubs-mips.cc:5929: // hash = character + (character << 10); comment is outdated http://codereview.chromium.org/9086006/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/9086006/diff/1/src/objects.cc#newcode6696 src/objects.cc:6696: #endif I think this should be checked only when slow assertions are enabled. http://codereview.chromium.org/9086006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
