LGTM, formatting suggestion below.
http://codereview.chromium.org/9008012/diff/7001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/9008012/diff/7001/src/runtime.cc#newcode1400 src/runtime.cc:1400: RETURN_IF_EMPTY_HANDLE(isolate, No biggy, I prefer my first suggestion (but you may disagree): RETURN_IF_EMPTY_HANDLE( isolate, JSReceiver::SetProperty(object, name, initial_value, mode, kNonStrictMode)); One fewer line, doesn't run to the right as fast (so scales better), and breaks the line at a better logical place---the commas in the outer RETURN_IF_EMPTY_HANDLE argument list don't bind as "tightly" as the commas in the nested SetProperty argument list. http://codereview.chromium.org/9008012/diff/7001/src/runtime.cc#newcode1443 src/runtime.cc:1443: RETURN_IF_EMPTY_HANDLE(isolate, Same story: RETURN_IF_EMPTY_HANDLE( isolate, JSReceiver::SetProperty(object, name, value, mode, kNonStrictMode)); Here you'll have the kind-of unsightly dangling '(', might as well try to have it at a place that binds least tightly in the expression. http://codereview.chromium.org/9008012/diff/7001/src/runtime.cc#newcode1554 src/runtime.cc:1554: RETURN_IF_EMPTY_HANDLE(isolate, Same story: RETURN_IF_EMPTY_HANDLE( isolate, JSReceiver::SetProperty(global, name, value, attributes, kNonStrictMode)); http://codereview.chromium.org/9008012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
