Reviewers: rossberg,

Description:
Fix broken test that assumes that no GC can clear the regexp
cache (GC can happen at any time due to Crankshaft).

Please review this at http://codereview.chromium.org/9113012/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     test/cctest/test-api.cc


Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc     (revision 10337)
+++ test/cctest/test-api.cc     (working copy)
@@ -14238,9 +14238,9 @@
" for (var i = 0; i < 16; i++) values[i] = %_GetFromCache(0, keys[i]);"
       "  for (var i = 0; i < 16; i++) {"
       "    var v = %_GetFromCache(0, keys[i]);"
-      "    if (v !== values[i])"
+      "    if (v.toString() !== values[i].toString())"
       "      return 'Wrong value for ' + "
-      "          keys[i] + ': ' + v + ' vs. ' + values[i];"
+      "          keys[i] + ': ' + v + ' vs. ' + values[i] + '';"
       "  };"
       "  return 'PASSED';"
       "})()";


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to