Revision: 10373
Author: [email protected]
Date: Tue Jan 10 08:12:24 2012
Log: Changes after code review#
http://code.google.com/p/v8/source/detail?r=10373
Modified:
/branches/bleeding_edge/src/factory.h
/branches/bleeding_edge/src/heap.h
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/factory.h Tue Jan 10 08:11:33 2012
+++ /branches/bleeding_edge/src/factory.h Tue Jan 10 08:12:24 2012
@@ -69,6 +69,7 @@
Handle<DeoptimizationOutputData> NewDeoptimizationOutputData(
int deopt_entry_count,
PretenureFlag pretenure);
+ // Allocates a pre-tenured empty AccessorPair.
Handle<AccessorPair> NewAccessorPair();
Handle<String> LookupSymbol(Vector<const char> str);
=======================================
--- /branches/bleeding_edge/src/heap.h Tue Jan 10 08:11:33 2012
+++ /branches/bleeding_edge/src/heap.h Tue Jan 10 08:12:24 2012
@@ -615,8 +615,8 @@
// Allocates an empty PolymorphicCodeCache.
MUST_USE_RESULT MaybeObject* AllocatePolymorphicCodeCache();
- // Allocates an empty AccessorPair.
- MaybeObject* AllocateAccessorPair();
+ // Allocates a pre-tenured empty AccessorPair.
+ MUST_USE_RESULT MaybeObject* AllocateAccessorPair();
// Clear the Instanceof cache (used when a prototype changes).
inline void ClearInstanceofCache();
=======================================
--- /branches/bleeding_edge/src/objects.cc Tue Jan 10 08:12:16 2012
+++ /branches/bleeding_edge/src/objects.cc Tue Jan 10 08:12:24 2012
@@ -4733,7 +4733,7 @@
PropertyDetails details = dictionary->DetailsAt(entry);
if (details.type() == CALLBACKS) {
if (element->IsAccessorPair()) {
- AccessorPair *accessors = AccessorPair::cast(element);
+ AccessorPair* accessors = AccessorPair::cast(element);
return is_getter ? accessors->getter() : accessors->setter();
}
}
@@ -4751,7 +4751,7 @@
if (result.type() == CALLBACKS) {
Object* obj = result.GetCallbackObject();
if (obj->IsAccessorPair()) {
- AccessorPair *accessors = AccessorPair::cast(obj);
+ AccessorPair* accessors = AccessorPair::cast(obj);
return is_getter ? accessors->getter() : accessors->setter();
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
