LGTM with comments.
http://codereview.chromium.org/9167011/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/9167011/diff/1/src/hydrogen-instructions.h#newcode3014 src/hydrogen-instructions.h:3014: : Representation::None(); "return Representation::Tagged();" should suffice, as index == 0 is always true. http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc#newcode2938 src/x64/lithium-codegen-x64.cc:2938: Register global_object = rdx; Unused variable. Also, s/rdx/rcx/. http://codereview.chromium.org/9167011/diff/1/src/x64/lithium-codegen-x64.cc#newcode2945 src/x64/lithium-codegen-x64.cc:2945: #ifdef _WIN64 If you made use of the |global_object| variable defined above, you wouldn't need this #ifdef. http://codereview.chromium.org/9167011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
