LGTM (with a nit).
http://codereview.chromium.org/9158015/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/9158015/diff/1/src/arm/lithium-codegen-arm.cc#newcode2145 src/arm/lithium-codegen-arm.cc:2145: isolate()->factory()->NewJSGlobalPropertyCell( Can we use factory() instead of isolate()->factory() here? Makes the line shorter. http://codereview.chromium.org/9158015/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): http://codereview.chromium.org/9158015/diff/1/test/cctest/test-heap.cc#newcode1497 test/cctest/test-heap.cc:1497: "f(new foo()); g();"); As discussed offline, the call to g() could probably be removed at this point. But Slava and I agreed that we should leave it in to not mess with the original repro. http://codereview.chromium.org/9158015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
