LGTM with 2 nits...
http://codereview.chromium.org/9177001/diff/4001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): http://codereview.chromium.org/9177001/diff/4001/src/hydrogen-instructions.cc#newcode793 src/hydrogen-instructions.cc:793: if (op() == Token::BIT_XOR) return this; I don't think we need this special case, because 'x ^ 0 == x', just like 'x | 0 == x'. http://codereview.chromium.org/9177001/diff/4001/src/hydrogen-instructions.cc#newcode795 src/hydrogen-instructions.cc:795: int nop_constant = (op() == Token::BIT_AND) ? -1 : 0; Use int32_t, not int. http://codereview.chromium.org/9177001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
