Approach looks good. I have only a few small comments for now.


http://codereview.chromium.org/9147034/diff/5001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/9147034/diff/5001/src/hydrogen.cc#newcode5149
src/hydrogen.cc:5149: HInstruction* left_cvt =
maybe use HChange* instead (it's shorter and a better fit)

http://codereview.chromium.org/9147034/diff/5001/src/hydrogen.cc#newcode5153
src/hydrogen.cc:5153: HInstruction* right_cvt =
HChange* also here.

http://codereview.chromium.org/9147034/diff/5001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/9147034/diff/5001/src/ia32/lithium-codegen-ia32.cc#newcode3850
src/ia32/lithium-codegen-ia32.cc:3850: bool deoptmize_on_minus_zero =
s/deoptmize/deoptimize/g

http://codereview.chromium.org/9147034/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to