Revision: 10390
Author: [email protected]
Date: Wed Jan 11 07:10:56 2012
Log: Correct nits in d8 ArrayBuffer() implementation
[email protected]
BUG=none
TEST=external-array.js
Review URL: http://codereview.chromium.org/9185006
http://code.google.com/p/v8/source/detail?r=10390
Modified:
/branches/bleeding_edge/src/d8.cc
/branches/bleeding_edge/test/mjsunit/external-array.js
=======================================
--- /branches/bleeding_edge/src/d8.cc Wed Jan 11 06:42:58 2012
+++ /branches/bleeding_edge/src/d8.cc Wed Jan 11 07:10:56 2012
@@ -387,8 +387,8 @@
}
if (offset > array_buffer_length) {
- return ThrowException(
- String::New("byteOffset must be less than ArrayBuffer
length."));
+ return ThrowException(
+ String::New("byteOffset must be less than ArrayBuffer length."));
}
if (args.Length() == 2) {
=======================================
--- /branches/bleeding_edge/test/mjsunit/external-array.js Wed Jan 11
06:42:58 2012
+++ /branches/bleeding_edge/test/mjsunit/external-array.js Wed Jan 11
07:10:56 2012
@@ -1,4 +1,4 @@
-// Copyright 2011 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -60,12 +60,6 @@
var derived_uint32_3 = new Uint32Array(ab,4,1);
assertEquals(1, derived_uint32_3.length);
-// Resulting array length of zero should fail.
-function abfunc2() {
- new Uint32Array(ab,3);
-}
-assertThrows(abfunc2);
-
// If a given byteOffset and length references an area beyond the end of
the
// ArrayBuffer an exception is raised.
function abfunc3() {
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
