LGTM with a bunch of nits.
http://codereview.chromium.org/9207002/diff/1/src/arm/deoptimizer-arm.cc File src/arm/deoptimizer-arm.cc (right): http://codereview.chromium.org/9207002/diff/1/src/arm/deoptimizer-arm.cc#newcode1 src/arm/deoptimizer-arm.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/9207002/diff/1/src/compiler.cc#newcode1 src/compiler.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/compiler.h File src/compiler.h (right): http://codereview.chromium.org/9207002/diff/1/src/compiler.h#newcode1 src/compiler.h:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/9207002/diff/1/src/heap.cc#newcode1 src/heap.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): http://codereview.chromium.org/9207002/diff/1/src/ia32/deoptimizer-ia32.cc#newcode1 src/ia32/deoptimizer-ia32.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/mips/deoptimizer-mips.cc File src/mips/deoptimizer-mips.cc (right): http://codereview.chromium.org/9207002/diff/1/src/mips/deoptimizer-mips.cc#newcode1 src/mips/deoptimizer-mips.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/9207002/diff/1/src/objects-inl.h#newcode1 src/objects-inl.h:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/9207002/diff/1/src/objects.cc#newcode8020 src/objects.cc:8020: function->shared()->PrintName(out); nit: since you defined JSFunction::PrintName(...), this change seems unnecessary, but I don't mind if you leave it in. http://codereview.chromium.org/9207002/diff/1/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9207002/diff/1/src/objects.h#newcode5195 src/objects.h:5195: // Disable (further) attempted optimization of all functions sharing this nit: truncated comment (missing "shared function info.") http://codereview.chromium.org/9207002/diff/1/src/objects.h#newcode5286 src/objects.h:5286: static const int kDeoptCounterOffset = Rename this to kStressDeoptCounterOffset? http://codereview.chromium.org/9207002/diff/1/src/runtime.h File src/runtime.h (right): http://codereview.chromium.org/9207002/diff/1/src/runtime.h#newcode1 src/runtime.h:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): http://codereview.chromium.org/9207002/diff/1/src/x64/deoptimizer-x64.cc#newcode1 src/x64/deoptimizer-x64.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/diff/1/test/mjsunit/assert-opt-and-deopt.js File test/mjsunit/assert-opt-and-deopt.js (right): http://codereview.chromium.org/9207002/diff/1/test/mjsunit/assert-opt-and-deopt.js#newcode1 test/mjsunit/assert-opt-and-deopt.js:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 http://codereview.chromium.org/9207002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
