Please make sure that we have test coverage of the different cases in the
stub.
On 2012/01/16 14:25:07, fschneider wrote:
LGTM.
http://codereview.chromium.org/9179010/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
http://codereview.chromium.org/9179010/diff/1/src/x64/code-stubs-x64.cc#newcode2314
src/x64/code-stubs-x64.cc:2314: // rsp[16] : receiver displacement
The comment is misleading: This argument is an absolute address, not a
displacement.
http://codereview.chromium.org/9179010/diff/1/src/x64/code-stubs-x64.cc#newcode2454
src/x64/code-stubs-x64.cc:2454: __ Integer64PlusConstantToSmi(r9, rbx, 0);
Isn't there an instruction to make a smi without adding a constant?
http://codereview.chromium.org/9179010/diff/1/src/x64/code-stubs-x64.cc#newcode2496
src/x64/code-stubs-x64.cc:2496: // Untag rcx and r8 for the loop below.
Comment should say: Untag rcx for the loop below.
(r8 already untagged)
http://codereview.chromium.org/9179010/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
http://codereview.chromium.org/9179010/diff/1/src/x64/full-codegen-x64.cc#newcode225
src/x64/full-codegen-x64.cc:225: // Arguments to ArgumentsAccessStub
and/or
New...:
What's "New..."? I think the comment was fine as it was.
http://codereview.chromium.org/9179010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
