Reviewers: Erik Corry,

Message:
PTAL.


http://codereview.chromium.org/9231017/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/9231017/diff/1/src/runtime.cc#newcode3290
src/runtime.cc:3290: const int kRecursionLimit = 0x1000;
Recursion limit is chosen so that regexpdna still benefits from this
fast path.

http://codereview.chromium.org/9231017/diff/1/src/string.js
File src/string.js (right):

http://codereview.chromium.org/9231017/diff/1/src/string.js#newcode248
src/string.js:248: subject.length > 0xFF &&
Dealing with short cons string the old way is better than traversing it.
 This especially makes celtic kane happy.

Description:
Recursion limit for one-char string replace and retire
String::kMinNonFlatLength.


TEST=mjsunit/string-replace-one-char.js


Please review this at http://codereview.chromium.org/9231017/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/arm/code-stubs-arm.cc
  M src/heap.cc
  M src/ia32/code-stubs-ia32.cc
  M src/mips/code-stubs-mips.cc
  M src/objects-debug.cc
  M src/objects.h
  M src/runtime.h
  M src/runtime.cc
  M src/string.js
  M src/x64/code-stubs-x64.cc
  M test/cctest/test-strings.cc
  A test/mjsunit/string-replace-one-char.js


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to