Reviewers: Yang,
Message:
PTAQL.
Description:
Move WIN32 define from standalone.gypi to common.gypi
BUG=v8:1760
Please review this at https://chromiumcodereview.appspot.com/9231018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M build/common.gypi
M build/standalone.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
cd8d98eeb7e58f41362bae41337b0f4458f99cae..e372af6f8533f53d0f2f30b0566a8695d7940c63
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -208,6 +208,11 @@
'COMPRESS_STARTUP_DATA_BZ2',
],
}],
+ ['OS=="win"', {
+ 'defines': [
+ 'WIN32',
+ ],
+ }],
['OS=="win" and v8_enable_prof==1', {
'msvs_settings': {
'VCLinkerTool': {
@@ -227,7 +232,7 @@
['OS=="solaris"', {
'defines': [ '__C99FEATURES__=1' ], # isinf() etc.
}],
- ],
+ ], # conditions
'configurations': {
'Debug': {
'defines': [
@@ -268,7 +273,7 @@
'-Wnon-virtual-dtor' ],
}],
],
- },
+ }, # Debug
'Release': {
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \
@@ -308,7 +313,7 @@
# is specified explicitly.
'GCC_STRICT_ALIASING': 'YES',
},
- }],
+ }], # OS=="mac"
['OS=="win"', {
'msvs_configuration_attributes': {
'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)',
@@ -343,9 +348,9 @@
# 'StackReserveSize': '297152',
},
},
- }],
- ],
- },
- },
- },
+ }], # OS=="win"
+ ], # conditions
+ }, # Release
+ }, # configurations
+ }, # target_defaults
}
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
86f6d46092421a41545421306e8687eb4c93e901..e9b056580deddf541e3664aa74ff0c61c1b31e4f
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -106,7 +106,6 @@
['OS=="win"', {
'target_defaults': {
'defines': [
- 'WIN32',
'_CRT_SECURE_NO_DEPRECATE',
'_CRT_NONSTDC_NO_DEPRECATE',
],
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
