Reviewers: Yang,
Message:
PTAL.
Description:
Provide a switch to specify -fno-strict-aliasing
BUG=1887
Please review this at https://chromiumcodereview.appspot.com/9231019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile
M build/common.gypi
Index: Makefile
diff --git a/Makefile b/Makefile
index
833c8758d976ef502cccd765fa7a2dbf2acb00e0..73e84216b4d9c470b6e9bcadfd7ea7b7af53a651
100644
--- a/Makefile
+++ b/Makefile
@@ -87,6 +87,10 @@ endif
ifeq ($(presubmit), no)
TESTFLAGS += --no-presubmit
endif
+# strictaliasing=off (workaround for GCC-4.5)
+ifeq ($(strictaliasing), off)
+ GYPFLAGS += -Dv8_no_strict_aliasing=1
+endif
# ----------------- available targets: --------------------
# - "dependencies": pulls in external dependencies (currently: GYP)
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
e372af6f8533f53d0f2f30b0566a8695d7940c63..c1c2b4272f7eede7e8ccbcf494b0c9d4b40bac46
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -73,6 +73,9 @@
# Enable profiling support. Only required on Windows.
'v8_enable_prof%': 0,
+ # Some versions of GCC 4.5 seem to need -fno-strict-aliasing.
+ 'v8_no_strict_aliasing%': 0,
+
# Chrome needs this definition unconditionally. For standalone V8
builds,
# it's handled in build/standalone.gypi.
'want_separate_host_toolset%': 1,
@@ -227,7 +230,10 @@
'cflags': [ '-m32' ],
'ldflags': [ '-m32' ],
}],
- ],
+ [ 'v8_no_strict_aliasing==1', {
+ 'cflags': [ '-fno-strict-aliasing' ],
+ }],
+ ], # conditions
}],
['OS=="solaris"', {
'defines': [ '__C99FEATURES__=1' ], # isinf() etc.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
