Reviewers: fschneider,

Description:
Revert "Immediately use the generic stub when storing into COW arrays"

Due to unexpected performance implications.

This reverts r10429.


Please review this at https://chromiumcodereview.appspot.com/9150032/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/ic.cc


Index: src/ic.cc
diff --git a/src/ic.cc b/src/ic.cc
index 1026f6d40f8f15d1e189e97addf96ff719153a34..4361ba2ee0b80e02a11391b76ad25887b1064fcd 100644
--- a/src/ic.cc
+++ b/src/ic.cc
@@ -1677,9 +1677,6 @@ MaybeObject* KeyedStoreIC::Store(State state,
       if (receiver->elements()->map() ==
           isolate()->heap()->non_strict_arguments_elements_map()) {
         stub = non_strict_arguments_stub();
-      } else if (receiver->elements()->map() ==
-          isolate()->heap()->fixed_cow_array_map()) {
-        // Do nothing, just keep the generic stub.
       } else if (!force_generic) {
         if (key->IsSmi() && (target() != *non_strict_arguments_stub())) {
           StubKind stub_kind = STORE_NO_TRANSITION;


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to