LGTM with nits.

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.cc
File src/d8-debug.cc (right):

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.cc#newcode1
src/d8-debug.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h
File src/d8-debug.h (right):

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h#newcode1
src/d8-debug.h:1: // Copyright 2008 the V8 project authors. All rights
reserved.
nit: 2012

http://codereview.chromium.org/9200006/diff/1/src/d8-debug.h#newcode56
src/d8-debug.h:56: explicit RemoteDebugger(int port, Handle<Context>
context)
nit: "explicit" is no longer necessary.

http://codereview.chromium.org/9200006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to