http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py File tools/presubmit.py (left):
http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py#oldcode231 tools/presubmit.py:231: return process.returncode == 0 On 2012/01/20 14:56:22, Jakob wrote:
I think we still want a return value here. IIUC, it should be: return sum(results) == 0
Done. http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py File tools/presubmit.py (right): http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py#newcode125 tools/presubmit.py:125: child.kill() On 2012/01/20 14:56:22, Jakob wrote:
I think you meant s/child/process/
This is actually interesting. Previously the script only reacted to ctrl+c because child.kill() results in a syntax error and get the worker killed. But of course your solution is the better one. http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py#newcode129 tools/presubmit.py:129: child.kill() On 2012/01/20 14:56:22, Jakob wrote:
same here.
Done. http://codereview.chromium.org/9192010/diff/1/tools/presubmit.py#newcode246 tools/presubmit.py:246: results = pool.map(CppLintWorker, commands) On 2012/01/20 14:56:22, Jakob wrote:
I need the following patch to make this react properly to Ctrl+C: - results = pool.map(CppLintWorker, commands) + # workaround for http://bugs.python.org/issue8296 + results = pool.map_async(CppLintWorker, commands).get(999999)
Done. http://codereview.chromium.org/9192010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
