Assuming that there is no generated code equivalent to
KeyedLookupCache::Update,
this LGTM with one small comment.
https://chromiumcodereview.appspot.com/9193015/diff/1/src/heap.h
File src/heap.h (right):
https://chromiumcodereview.appspot.com/9193015/diff/1/src/heap.h#newcode2142
src/heap.h:2142: static const int kEntriesPerBucket = 4;
Maybe add assertions such as
STATIC_ASSERT(IS_POWER_OF_TWO(kEntriesPerBucket));
STATIC_ASSERT(kHashMask == -kEntriesPerBucket)
https://chromiumcodereview.appspot.com/9193015/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
