On Tue, Jan 24, 2012 at 02:32, <[email protected]> wrote: > Reviewers: Kevin Millikin, > > Description: > Put a slow assert under the enable_slow_asserts flag. > > Otherwise really large functions take too long to compile > in debug mode. [...] >
IIRC, this is the place where v8 basically "hangs" when it tries to compile Mandreel code. The CL is basically a quick workaround, but it still leaves slow asserts in an unusable state for Mandreel apps (quadratic complexity in the number of bailout IDs, and Mandreel apps have *lots* of these). IMHO using a set instead of a list would be better. The only thing I am not 100% sure of is PopulateOptimizationData: Is the order we visit the entries important here or not? If yes, the entries would need more info or we would have to use a "sorted" set (as much as I hate that word ;-). Cheers, S. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
