Revision: 10488
Author:   [email protected]
Date:     Tue Jan 24 05:07:21 2012
Log:      Fix bug 542, misleading documentation of v8::Locker.
Review URL: https://chromiumcodereview.appspot.com/9160028
http://code.google.com/p/v8/source/detail?r=10488

Modified:
 /branches/bleeding_edge/include/v8.h

=======================================
--- /branches/bleeding_edge/include/v8.h        Fri Jan 13 07:14:45 2012
+++ /branches/bleeding_edge/include/v8.h        Tue Jan 24 05:07:21 2012
@@ -2717,7 +2717,7 @@
  * default isolate is implicitly created and entered.  The embedder
  * can create additional isolates and use them in parallel in multiple
  * threads.  An isolate can be entered by at most one thread at any
- * given time.  The Locker/Unlocker API can be used to synchronize.
+ * given time.  The Locker/Unlocker API must be used to synchronize.
  */
 class V8EXPORT Isolate {
  public:
@@ -3559,7 +3559,9 @@
  * accessing handles or holding onto object pointers obtained
  * from V8 handles while in the particular V8 isolate.  It is up
  * to the user of V8 to ensure (perhaps with locking) that this
- * constraint is not violated.
+ * constraint is not violated.  In addition to any other synchronization
+ * mechanism that may be used, the v8::Locker and v8::Unlocker classes
+ * must be used to signal thead switches to V8.
  *
  * v8::Locker is a scoped lock object. While it's
* active (i.e. between its construction and destruction) the current thread is

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to