https://chromiumcodereview.appspot.com/9212045/diff/1/src/mark-compact.cc File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/9212045/diff/1/src/mark-compact.cc#newcode1675 src/mark-compact.cc:1675: bool MarkCompactCollector::MarkUnmarked(Object* value) { The name is kind of misleading, because it not only handles unmarked objects, but marked ones as well. My suggestion is rename this to use a different signature and also to move it to mark-compact-inl.h. Proposed new signature is: void MarkCompactCollector::MarkObject(HeapObject* obj); https://chromiumcodereview.appspot.com/9212045/diff/1/src/mark-compact.cc#newcode1684 src/mark-compact.cc:1684: bool MarkCompactCollector::MarkUnmarkedAndPush(Object* value) { Boolean return value is never used, can we drop it? Can we also move this to mark-compact-inl.h and rename it to MarkObjectAndPush()? https://chromiumcodereview.appspot.com/9212045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
