http://codereview.chromium.org/9141016/diff/8001/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/9141016/diff/8001/src/hydrogen.cc#newcode1494 src/hydrogen.cc:1494: // instruction. In general a path from the header to the current instruction may involve all blocks from the loop that are not dominated by the current instruction. preceeding_loop_depends accumulates the dependencies of the blocks with an id less than the current block, and therefore can be missing the ones of blocks with higher ids that are not dominated by the current instruction. http://codereview.chromium.org/9141016/diff/8001/src/hydrogen.cc#newcode1495 src/hydrogen.cc:1495: can_hoist = Please add a unit test that covers the two cases that can occur here: hoisting and not hoisting the instruction. http://codereview.chromium.org/9141016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
