LGTM (if comments are addressed).
https://chromiumcodereview.appspot.com/9169045/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/9169045/diff/1/src/mark-compact.cc#newcode2367 src/mark-compact.cc:2367: void MarkCompactCollector::ClearNonLiveMapTransitions(Map* map, bool marked) { I don't like boolean flags, they are very confusing. Can we instead pass the map's MarkBit (i.e. map_mark)? Thereby you can reuse that as the initial current_mark value as well and it is clear what that argument means. https://chromiumcodereview.appspot.com/9169045/diff/1/src/mark-compact.cc#newcode2382 src/mark-compact.cc:2382: MarkBit current_mark = Marking::MarkBitFrom(current); Like the above comment said: Initialize outside of loop and update at end of loop after line 2398. https://chromiumcodereview.appspot.com/9169045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
