We should look into it. We would need (1) to install LLVM, Clang, and IWYU on the buildbot (if we wanted to run it there), (2) to write a parser for the output to look for violations---maybe there's a way to get the tool to say simply yes or no, but I don't know it, and (3) some sort of suppression mechanism because there will probably be deliberate violations in V8.
The tool may not be ready for use as a presubmit check. It still has some rough edges. It is somehow confused by uses of our higher-order macros to generate forward declarations. For ast.h, the tool recommends that we remove all the forward declarations for AST nodes, and also that we add forward declarations for all the AST nodes :) Another likely bug in the tool is that the recommendations don't seem completely stable. For instance, running the tool will recommend that we include contexts.h. Including contexts.h and rerunning the tool will recommend that it contexts.h is not needed and should be removed. Rerunning the tool, is back to the initial state. I'll throw up a post or wiki page describing how to run it when I get a chance. On Wed, Jan 25, 2012 at 8:23 AM, <[email protected]> wrote: > On 2012/01/25 02:22:05, fschneider wrote: > >> LGTM if it compiles. >> > > I assume you are going to fix all source files... Would it be possible to > hook > up this tool to check includes into presubmit in some way? > > https://chromiumcodereview.**appspot.com/9288011/<https://chromiumcodereview.appspot.com/9288011/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
