lgtm. Have you tried other values than 10? I'm not sure if we actually need a flag once we figure out a reasonable value for the weights.
https://chromiumcodereview.appspot.com/8277031/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/8277031/diff/1/src/hydrogen-instructions.cc#newcode77 src/hydrogen-instructions.cc:77: static const int weights[] = { 1, w, w*w, w*w*w, w*w*w*w }; I think no need for static here. Actually, I'd also be fine with hard-coding the weight to 10 here, so that the compiler can inline the constants. Once set, we probably don't need to change it often. https://chromiumcodereview.appspot.com/8277031/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
