http://codereview.chromium.org/9297052/diff/1/src/zone.cc File src/zone.cc (right):
http://codereview.chromium.org/9297052/diff/1/src/zone.cc#newcode30 src/zone.cc:30: #include "allocation.h" On 2012/01/30 09:25:45, Kevin Millikin wrote:
You are welcome to leave allocation.h out since it comes to us via
zone-inl.h
(or put it in, I don't much care).
Please include headers in this order:
#include "v8.h" #include "zone-inl.h"
#include <string.h> #include "allocation.h"
The first block are those that (possibly) can't be reordered, and they
are
intentionally not alphabetized. v8.h is first because it contains all
the
included that have circular dependencies included in just the right
order. Our presubmit script however says: zone.cc:31: Found C system header after other header. Should be: zone.h, c system, c++ system, other. I guess I'll move string.h to the top. http://codereview.chromium.org/9297052/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
