I guess this is OK, but I'd prefer to make the presubmit tools work for us, rather than making us work for the tools.
In the case of "v8.h", it really should be before anything else because it contains the includes that are sensitive to order until and unless we untangle them. The fix is to modify V8's own coding style so that the the include order: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_and_Order_of_Includes#Names_and_Order_of_Includes has an item "0. v8.h". On Mon, Jan 30, 2012 at 11:47 AM, <[email protected]> wrote: > LGTM. > > https://chromiumcodereview.**appspot.com/9297058/<https://chromiumcodereview.appspot.com/9297058/> > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
