https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc File src/objects.cc (left):
https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#oldcode7295 src/objects.cc:7295: ASSERT(target->prototype() == this || Can we keep this assertion around? If we turn RestorePrototype into a member of Map, this assertion can be placed in there. https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#oldcode7312 src/objects.cc:7312: ASSERT(target->prototype() == this || Likewise. https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#oldcode7321 src/objects.cc:7321: // If no map was found, make sure the FixedArray also gets collected. Can we keep this comment (and place it above line 7363 on the right side)? https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#newcode7287 src/objects.cc:7287: static bool RestoreProto(Object* object, I would prefer "RestorePrototype" as a name. Also a comment of what the semantics of keep_entry and the return value are, is needed here I think. Just an idea: Since this is the diametrical opposite of Map::CreateOneBackPointer, why not make it a member if Map and call it something like RestoreOneBackPointer? https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#newcode7291 src/objects.cc:7291: Map* map = static_cast<Map*>(object); If object->IsMap() is usable at this point, then Map::cast() is as well. I would suggest using that instead of a static_cast<> here. https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#newcode7303 src/objects.cc:7303: // Live DescriptorArray objects will be marked, so we must use low-level The comment is no longer accurate. https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#newcode7305 src/objects.cc:7305: DescriptorArray* d = static_cast<DescriptorArray*>( I think we can use our internal casts here. Could you please verify that? https://chromiumcodereview.appspot.com/9225056/diff/1/src/objects.cc#newcode7310 src/objects.cc:7310: FixedArray* contents = static_cast<FixedArray*>( Likewise. https://chromiumcodereview.appspot.com/9225056/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
