Nit: DeoptimizedFrameInfo::pc_ is not handled during gc (in DeoptimizedFrameInfo::Iterate) unlike all other frame components.
Vyacheslav Egorov On Jan 30, 2012 1:27 PM, <[email protected]> wrote: > lgtm > > > > > http://codereview.chromium.**org/9295014/diff/2002/test/** > cctest/test-debug.cc<http://codereview.chromium.org/9295014/diff/2002/test/cctest/test-debug.cc> > File test/cctest/test-debug.cc (right): > > http://codereview.chromium.**org/9295014/diff/2002/test/** > cctest/test-debug.cc#**newcode7307<http://codereview.chromium.org/9295014/diff/2002/test/cctest/test-debug.cc#newcode7307> > test/cctest/test-debug.cc:**7307: // Each frame's source position has to > be different from the previous one. > Maybe put in expected lines > > int expected_line[..] = {1, 4, ...} > > and check for the actual line > > CHECK_EQ(expected_line[i] = result->Int32Value(); > > http://codereview.chromium.**org/9295014/<http://codereview.chromium.org/9295014/> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/**group/v8-dev<http://groups.google.com/group/v8-dev> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
