LGTM (with nits). I left platform specific nits in ia32, but they apply to
all
of them.
https://chromiumcodereview.appspot.com/9235007/diff/44/src/contexts.h
File src/contexts.h (right):
https://chromiumcodereview.appspot.com/9235007/diff/44/src/contexts.h#newcode380
src/contexts.h:380: return SMI_JS_ARRAY_MAP_INDEX;
Can we prefix this with "Context::" as well for clarity.
https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):
https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc#newcode866
src/ia32/ic-ia32.cc:866: // Escape to slow case when writing non-smi
into smi-only array.
This comment is no longer accurate.
https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/ic-ia32.cc#newcode923
src/ia32/ic-ia32.cc:923: // Elements are FAST_DOUBLE_WITHOUT_MAP_CHECK,
but value is an Object that's
This constant seems bogus.
https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/macro-assembler-ia32.h
File src/ia32/macro-assembler-ia32.h (right):
https://chromiumcodereview.appspot.com/9235007/diff/44/src/ia32/macro-assembler-ia32.h#newcode235
src/ia32/macro-assembler-ia32.h:235: // Load the initial map for a new
Arrays from a JSFunction.
Drop the "a" in the comment.
https://chromiumcodereview.appspot.com/9235007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
