Reviewers: danno,

Description:
Merged r10582 into 3.8 branch.

Do not ignore an empty context with extension when creating a scope object.

BUG=crbug.com/107996

[email protected]
TEST=


Please review this at https://chromiumcodereview.appspot.com/9307054/

SVN Base: https://v8.googlecode.com/svn/branches/3.8

Affected files:
  M src/scopes.cc
  M src/version.cc


Index: src/scopes.cc
diff --git a/src/scopes.cc b/src/scopes.cc
index d0ee8ec7f21af11758a2cb3c49dcf9f8a2aa6b18..a7ff28789f17b679eb650094bdec35cc28f744ad 100644
--- a/src/scopes.cc
+++ b/src/scopes.cc
@@ -149,12 +149,10 @@ Scope::Scope(Scope* inner_scope,
   SetDefaults(type, NULL, scope_info);
   if (!scope_info.is_null()) {
     num_heap_slots_ = scope_info_->ContextLength();
-    if (*scope_info != ScopeInfo::Empty()) {
-      language_mode_ = scope_info->language_mode();
-    }
-  } else if (is_with_scope()) {
-    num_heap_slots_ = Context::MIN_CONTEXT_SLOTS;
   }
+  // Ensure at least MIN_CONTEXT_SLOTS to indicate a materialized context.
+  num_heap_slots_ = Max(num_heap_slots_,
+                        static_cast<int>(Context::MIN_CONTEXT_SLOTS));
   AddInnerScope(inner_scope);
 }

Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index ff621b78acf0122041be3d9dca4c127a4b86584d..1022a5cde3d0eaa3d505c61e953e06ada3692fac 100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     8
 #define BUILD_NUMBER      9
-#define PATCH_LEVEL       4
+#define PATCH_LEVEL       5
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to