LGTM (if comment is addressed).

https://chromiumcodereview.appspot.com/9323002/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/9323002/diff/1/src/objects.h#newcode4376
src/objects.h:4376: // This constant should be encodable in an ARM
instruction.
I think we need to have a static-assert at the usage site in
stub-cache-arm.cc where this is relevant. Otherwise that promise will be
broken soon.

https://chromiumcodereview.appspot.com/9323002/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to