LGTM.
https://chromiumcodereview.appspot.com/9323004/diff/2002/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/9323004/diff/2002/src/arm/stub-cache-arm.cc#newcode223 src/arm/stub-cache-arm.cc:223: // Primary miss: Compute hash for secondary probe. Can the following sequence be rewritten like follows? It is your call whether to do that. __ sub(scratch, scratch, Operand(name, LSR, 1)); __ add(scratch, scratch, Operand(flags >> 1)); __ and_(scratch, scratch, Operand((kSecondaryTableSize - 1) << kHeapObjectTagSize - 1)); https://chromiumcodereview.appspot.com/9323004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
