http://codereview.chromium.org/9325019/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/9325019/diff/1/src/arm/lithium-arm.cc#newcode795 src/arm/lithium-arm.cc:795: if (!allocator_->AllocationOk()) Abort("Not enough virtual registers."); Abort in this case is doing exactly that, namely bailing out of the lithium construction by setting the is_aborted flag which is checked in LChunkBuilder::DoBasicBlock. On 2012/02/03 09:01:20, Sven wrote:
I am a little bit concerned about this 'Abort' (and the corresponding
ones in
other lithium-*.cc files): I don't think we aborted before if we
somehow ran out
of virtual registers, now we do. Either a comment is missing why this
will never
happen ;-) or this has to be handled differently, I think (bailing
out?). http://codereview.chromium.org/9325019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
