Florian: I'm inclined to agree with that analysis :-)
New patch set uploaded. https://chromiumcodereview.appspot.com/9221011/diff/4001/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9221011/diff/4001/src/ast.h#newcode1254 src/ast.h:1254: AstProperties* ast_properties_; On 2012/02/02 15:54:07, fschneider wrote:
It seems that we only visit the VariableProxy to filter out LOOKUP
slot
variables.
I think we can skip those when setting the kDontInline flag: If there
is no eval
or with-statement (which we can't optimize either), then there
shouldn't be any
variables of type LOOKUP.
(Even if there was, we would bailout safely from the Hydrogen graph
builder, and
abort optimization for the current function.)
Done. https://chromiumcodereview.appspot.com/9221011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
