LGTM
https://chromiumcodereview.appspot.com/9323007/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/9323007/diff/1/src/mark-compact.cc#newcode578 src/mark-compact.cc:578: space->CountFreeListItems(p, &sizes); This call worries me. It can potentially take a long time, and really all we need to know is whether there is a small number of live objects on the page. If the page consists of 100k objects and 100k gaps then we are not interested in it for the purposes of REDUCE_MEMORY_FOOTPRINT. So I think CountFreeList should take a maximum number of free list nodes to traverse. I think the other 2 places this is used would also benefit from a max argument. https://chromiumcodereview.appspot.com/9323007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
