http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h File src/objects-inl.h (right):
http://codereview.chromium.org/9320066/diff/1/src/objects-inl.h#newcode2014 src/objects-inl.h:2014: UNREACHABLE(); // keep the compiler happy On 2012/02/03 13:17:14, Jakob wrote:
nit: Leading capital letter and trailing period.
Done. http://codereview.chromium.org/9320066/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11143 src/objects.cc:11143: case INTERCEPTOR: On 2012/02/03 13:17:14, Jakob wrote:
nit: indentation
Done. http://codereview.chromium.org/9320066/diff/1/src/objects.cc#newcode11147 src/objects.cc:11147: UNREACHABLE(); // keep the compiler happy On 2012/02/03 13:17:14, Jakob wrote:
Missing capital and period.
Done. http://codereview.chromium.org/9320066/diff/1/src/property-details.h File src/property-details.h (right): http://codereview.chromium.org/9320066/diff/1/src/property-details.h#newcode1 src/property-details.h:1: // Copyright 2011 the V8 project authors. All rights reserved. On 2012/02/03 13:17:14, Jakob wrote:
nit: 2012
Done. http://codereview.chromium.org/9320066/diff/1/src/property.cc File src/property.cc (right): http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode1 src/property.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. On 2012/02/03 13:17:14, Jakob wrote:
nit: 2012
Done. http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode132 src/property.cc:132: case INTERCEPTOR: On 2012/02/03 13:17:14, Jakob wrote:
nit: indentation
Done. http://codereview.chromium.org/9320066/diff/1/src/property.cc#newcode136 src/property.cc:136: UNREACHABLE(); // keep the compiler happy On 2012/02/03 13:17:14, Jakob wrote:
Missing capital letter and period.
Done. http://codereview.chromium.org/9320066/diff/1/src/property.h File src/property.h (right): http://codereview.chromium.org/9320066/diff/1/src/property.h#newcode1 src/property.h:1: // Copyright 2011 the V8 project authors. All rights reserved. On 2012/02/03 13:17:14, Jakob wrote:
nit: 2012
Done. http://codereview.chromium.org/9320066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
