https://chromiumcodereview.appspot.com/9316092/diff/2004/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right):
https://chromiumcodereview.appspot.com/9316092/diff/2004/test/cctest/test-heap-profiler.cc#newcode831 test/cctest/test-heap-profiler.cc:831: // 1 -> 2, 1 -> 3 On 2012/02/03 14:23:41, Mikhail Naganov (Chromium) wrote:
Then please add "(note length = 2)" for clarity.
Done. https://chromiumcodereview.appspot.com/9316092/diff/2004/test/cctest/test-heap-profiler.cc#newcode836 test/cctest/test-heap-profiler.cc:836: v8::Persistent<v8::Value> objects_[4]; On 2012/02/03 14:23:41, Mikhail Naganov (Chromium) wrote:
OK, at least, please introduce a constant for the array length.
Done. https://chromiumcodereview.appspot.com/9316092/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
