Reviewers: Vyacheslav Egorov,
Message:
Second attempt at this. Behavior is described here:
http://code.google.com/p/chromium/issues/detail?id=60240#c31
In general those changes should not affect performance to begin with, since
they
only affect changes for devtools and the Error object.
Two problems I encountered:
- when the error object is constructed, we now have two stack walks. The
first
one gathers just a few information into a fixed array for the Error.stack
getter
to construct into a string later. The second one gathers more information
to be
displayed in devtools. Considering that the latter only kicks in devtools
where
we don't care too much about performance, there is no point combining both
stack
walks, which would drag down performance of the first stack walk, which is
always being done when an Error object is constructed.
- gathering message location is still only done at the throw site to avoid
confusing and contradicting error messages depending on whether devtools was
open when the error occurred.
Description:
When rethrowing an exception, print the stack trace of its original site
instead
of rethrow site.
BUG=60240
Please review this at http://codereview.chromium.org/9310122/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.h
M src/isolate.h
M src/isolate.cc
M src/messages.js
M src/runtime.h
M src/runtime.cc
M test/cctest/test-api.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
