Reviewers: Jakob,
Description:
Increase size of small stacks from 32k to 64k to avoid hitting
limits in Chromium.
http://code.google.com/p/chromium/issues/detail?id=112843
Please review this at https://chromiumcodereview.appspot.com/9353006/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/cpu-profiler.cc
M src/platform-freebsd.cc
M src/platform-linux.cc
M src/platform-macos.cc
M src/platform-openbsd.cc
M src/platform-solaris.cc
M src/platform-win32.cc
M test/cctest/test-mark-compact.cc
Index: src/cpu-profiler.cc
===================================================================
--- src/cpu-profiler.cc (revision 10614)
+++ src/cpu-profiler.cc (working copy)
@@ -42,7 +42,7 @@
static const int kEventsBufferSize = 256 * KB;
static const int kTickSamplesBufferChunkSize = 64 * KB;
static const int kTickSamplesBufferChunksCount = 16;
-static const int kProfilerStackSize = 32 * KB;
+static const int kProfilerStackSize = 64 * KB;
ProfilerEventsProcessor::ProfilerEventsProcessor(ProfileGenerator*
generator)
Index: src/platform-freebsd.cc
===================================================================
--- src/platform-freebsd.cc (revision 10614)
+++ src/platform-freebsd.cc (working copy)
@@ -710,7 +710,7 @@
FULL_INTERVAL
};
- static const int kSignalSenderStackSize = 32 * KB;
+ static const int kSignalSenderStackSize = 64 * KB;
explicit SignalSender(int interval)
: Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
Index: src/platform-linux.cc
===================================================================
--- src/platform-linux.cc (revision 10614)
+++ src/platform-linux.cc (working copy)
@@ -1060,7 +1060,7 @@
FULL_INTERVAL
};
- static const int kSignalSenderStackSize = 32 * KB;
+ static const int kSignalSenderStackSize = 64 * KB;
explicit SignalSender(int interval)
: Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
Index: src/platform-macos.cc
===================================================================
--- src/platform-macos.cc (revision 10614)
+++ src/platform-macos.cc (working copy)
@@ -733,7 +733,7 @@
class SamplerThread : public Thread {
public:
- static const int kSamplerThreadStackSize = 32 * KB;
+ static const int kSamplerThreadStackSize = 64 * KB;
explicit SamplerThread(int interval)
: Thread(Thread::Options("SamplerThread", kSamplerThreadStackSize)),
Index: src/platform-openbsd.cc
===================================================================
--- src/platform-openbsd.cc (revision 10614)
+++ src/platform-openbsd.cc (working copy)
@@ -782,7 +782,7 @@
FULL_INTERVAL
};
- static const int kSignalSenderStackSize = 32 * KB;
+ static const int kSignalSenderStackSize = 64 * KB;
explicit SignalSender(int interval)
: Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
Index: src/platform-solaris.cc
===================================================================
--- src/platform-solaris.cc (revision 10614)
+++ src/platform-solaris.cc (working copy)
@@ -704,7 +704,7 @@
FULL_INTERVAL
};
- static const int kSignalSenderStackSize = 32 * KB;
+ static const int kSignalSenderStackSize = 64 * KB;
explicit SignalSender(int interval)
: Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
Index: src/platform-win32.cc
===================================================================
--- src/platform-win32.cc (revision 10614)
+++ src/platform-win32.cc (working copy)
@@ -1894,7 +1894,7 @@
class SamplerThread : public Thread {
public:
- static const int kSamplerThreadStackSize = 32 * KB;
+ static const int kSamplerThreadStackSize = 64 * KB;
explicit SamplerThread(int interval)
: Thread(Thread::Options("SamplerThread", kSamplerThreadStackSize)),
Index: test/cctest/test-mark-compact.cc
===================================================================
--- test/cctest/test-mark-compact.cc (revision 10614)
+++ test/cctest/test-mark-compact.cc (working copy)
@@ -534,15 +534,15 @@
intptr_t booted_memory = MemoryInUse();
if (sizeof(initial_memory) == 8) {
if (v8::internal::Snapshot::IsEnabled()) {
- CHECK_LE(booted_memory - initial_memory, 6654 * 1024); // 6444.
+ CHECK_LE(booted_memory - initial_memory, 6686 * 1024); // 6476.
} else {
- CHECK_LE(booted_memory - initial_memory, 6777 * 1024); // 6596.
+ CHECK_LE(booted_memory - initial_memory, 6809 * 1024); // 6628.
}
} else {
if (v8::internal::Snapshot::IsEnabled()) {
- CHECK_LE(booted_memory - initial_memory, 6500 * 1024); // 6356.
+ CHECK_LE(booted_memory - initial_memory, 6532 * 1024); // 6388.
} else {
- CHECK_LE(booted_memory - initial_memory, 6654 * 1024); // 6424
+ CHECK_LE(booted_memory - initial_memory, 6686 * 1024); // 6456
}
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
