Revision: 10615
Author:   [email protected]
Date:     Tue Feb  7 00:00:36 2012
Log:      Increase size of small stacks from 32k to 64k to avoid hitting
limits in Chromium.
http://code.google.com/p/chromium/issues/detail?id=112843
Review URL: https://chromiumcodereview.appspot.com/9353006
http://code.google.com/p/v8/source/detail?r=10615

Modified:
 /branches/bleeding_edge/src/cpu-profiler.cc
 /branches/bleeding_edge/src/platform-freebsd.cc
 /branches/bleeding_edge/src/platform-linux.cc
 /branches/bleeding_edge/src/platform-macos.cc
 /branches/bleeding_edge/src/platform-openbsd.cc
 /branches/bleeding_edge/src/platform-solaris.cc
 /branches/bleeding_edge/src/platform-win32.cc
 /branches/bleeding_edge/test/cctest/test-mark-compact.cc

=======================================
--- /branches/bleeding_edge/src/cpu-profiler.cc Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/cpu-profiler.cc Tue Feb  7 00:00:36 2012
@@ -1,4 +1,4 @@
-// Copyright 2010 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
@@ -42,7 +42,7 @@
 static const int kEventsBufferSize = 256 * KB;
 static const int kTickSamplesBufferChunkSize = 64 * KB;
 static const int kTickSamplesBufferChunksCount = 16;
-static const int kProfilerStackSize = 32 * KB;
+static const int kProfilerStackSize = 64 * KB;


ProfilerEventsProcessor::ProfilerEventsProcessor(ProfileGenerator* generator)
=======================================
--- /branches/bleeding_edge/src/platform-freebsd.cc     Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/platform-freebsd.cc     Tue Feb  7 00:00:36 2012
@@ -710,7 +710,7 @@
     FULL_INTERVAL
   };

-  static const int kSignalSenderStackSize = 32 * KB;
+  static const int kSignalSenderStackSize = 64 * KB;

   explicit SignalSender(int interval)
       : Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
=======================================
--- /branches/bleeding_edge/src/platform-linux.cc       Tue Jan 31 00:41:16 2012
+++ /branches/bleeding_edge/src/platform-linux.cc       Tue Feb  7 00:00:36 2012
@@ -1060,7 +1060,7 @@
     FULL_INTERVAL
   };

-  static const int kSignalSenderStackSize = 32 * KB;
+  static const int kSignalSenderStackSize = 64 * KB;

   explicit SignalSender(int interval)
       : Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
=======================================
--- /branches/bleeding_edge/src/platform-macos.cc       Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/platform-macos.cc       Tue Feb  7 00:00:36 2012
@@ -733,7 +733,7 @@

 class SamplerThread : public Thread {
  public:
-  static const int kSamplerThreadStackSize = 32 * KB;
+  static const int kSamplerThreadStackSize = 64 * KB;

   explicit SamplerThread(int interval)
       : Thread(Thread::Options("SamplerThread", kSamplerThreadStackSize)),
=======================================
--- /branches/bleeding_edge/src/platform-openbsd.cc     Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/platform-openbsd.cc     Tue Feb  7 00:00:36 2012
@@ -782,7 +782,7 @@
     FULL_INTERVAL
   };

-  static const int kSignalSenderStackSize = 32 * KB;
+  static const int kSignalSenderStackSize = 64 * KB;

   explicit SignalSender(int interval)
       : Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
=======================================
--- /branches/bleeding_edge/src/platform-solaris.cc     Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/platform-solaris.cc     Tue Feb  7 00:00:36 2012
@@ -704,7 +704,7 @@
     FULL_INTERVAL
   };

-  static const int kSignalSenderStackSize = 32 * KB;
+  static const int kSignalSenderStackSize = 64 * KB;

   explicit SignalSender(int interval)
       : Thread(Thread::Options("SignalSender", kSignalSenderStackSize)),
=======================================
--- /branches/bleeding_edge/src/platform-win32.cc       Tue Jan 24 07:48:16 2012
+++ /branches/bleeding_edge/src/platform-win32.cc       Tue Feb  7 00:00:36 2012
@@ -1894,7 +1894,7 @@

 class SamplerThread : public Thread {
  public:
-  static const int kSamplerThreadStackSize = 32 * KB;
+  static const int kSamplerThreadStackSize = 64 * KB;

   explicit SamplerThread(int interval)
       : Thread(Thread::Options("SamplerThread", kSamplerThreadStackSize)),
=======================================
--- /branches/bleeding_edge/test/cctest/test-mark-compact.cc Tue Jan 31 05:33:44 2012 +++ /branches/bleeding_edge/test/cctest/test-mark-compact.cc Tue Feb 7 00:00:36 2012
@@ -1,4 +1,4 @@
-// Copyright 2006-2008 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
@@ -534,15 +534,15 @@
     intptr_t booted_memory = MemoryInUse();
     if (sizeof(initial_memory) == 8) {
       if (v8::internal::Snapshot::IsEnabled()) {
-        CHECK_LE(booted_memory - initial_memory, 6654 * 1024);  // 6444.
+        CHECK_LE(booted_memory - initial_memory, 6686 * 1024);  // 6476.
       } else {
-        CHECK_LE(booted_memory - initial_memory, 6777 * 1024);  // 6596.
+        CHECK_LE(booted_memory - initial_memory, 6809 * 1024);  // 6628.
       }
     } else {
       if (v8::internal::Snapshot::IsEnabled()) {
-        CHECK_LE(booted_memory - initial_memory, 6500 * 1024);  // 6356.
+        CHECK_LE(booted_memory - initial_memory, 6532 * 1024);  // 6388.
       } else {
-        CHECK_LE(booted_memory - initial_memory, 6654 * 1024);  // 6424
+        CHECK_LE(booted_memory - initial_memory, 6686 * 1024);  // 6456
       }
     }
   }

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to