LGTM
https://chromiumcodereview.appspot.com/9323079/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): https://chromiumcodereview.appspot.com/9323079/diff/1/src/incremental-marking.cc#newcode508 src/incremental-marking.cc:508: heap_->mark_compact_collector()->StartCompaction(true); If we are going to have boolean arguments we should at least have a comment on the call site to say what it means. https://chromiumcodereview.appspot.com/9323079/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/9323079/diff/1/src/mark-compact.cc#newcode252 src/mark-compact.cc:252: if (!incremental) { Please reverse the sense and order of this if. https://chromiumcodereview.appspot.com/9323079/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
