On 2012/02/07 09:17:37, Vyacheslav Egorov wrote:
lgtm
http://codereview.chromium.org/9310122/diff/7001/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/9310122/diff/7001/src/isolate.cc#newcode548
src/isolate.cc:548: Handle<String>
key(heap()->hidden_stack_trace_symbol());
you can use factory()->hidden_stack_trace_symbol(),
it returns handle.
http://codereview.chromium.org/9310122/diff/7001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/9310122/diff/7001/test/cctest/test-api.cc#newcode13655
test/cctest/test-api.cc:13655: // not where it is thrown.
Comment is incorrect. In this test stack trace is captured where it is
thrown.
Issues addressed. Landing.
http://codereview.chromium.org/9310122/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
