LGTM (with nits).
https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h File src/scanner.h (right): https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h#newcode56 src/scanner.h:56: kAllowModules = 16 Can we either change this constant (and the two above) to "1 << 4" or to "0x10"? I think that's more readable. https://chromiumcodereview.appspot.com/9352013/diff/1/src/scanner.h#newcode564 src/scanner.h:564: // Whether we scan 'module', 'import', 'export', and 'from' as keywords. I don't see "from" being a keyword in the scanner. https://chromiumcodereview.appspot.com/9352013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
