lgtm
https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newcode5061 src/hydrogen.cc:5061: bool HGraphBuilder::TryInlineBuiltinFunctionCall(Call* expr, bool drop_extra) { maybe it's time to have enum for drop_extra so it would be easier to read call sites. https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newcode5073 src/hydrogen.cc:5073: if (argument_count == 2) { I think you can just use expr->arguments()->length() == 1 here. https://chromiumcodereview.appspot.com/9365013/diff/3002/src/hydrogen.cc#newcode5080 src/hydrogen.cc:5080: if (drop_extra) Drop(1); // Optionally drop the function. It would be good to add test case that ensures that we deopt from inside LUnaryMathOperation with correct environment. https://chromiumcodereview.appspot.com/9365013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
