LGTM, I'll land. See my comment below for a suggested future improvement.
http://codereview.chromium.org/9361024/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/9361024/diff/1/build/common.gypi#newcode209 build/common.gypi:209: ['mips_arch_variant=="mips32r2"', { This works for now, but it's a bit brittle: it forces you to specify some value for mips_arch_variant whenever v8_target_arch=="mips", or gyp will fail. I'd suggest to add a default value to the top of this file (see the other examples there for the %-notation). http://codereview.chromium.org/9361024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
