LGTM with nits.
I think we can increase readability a bit by changing some of the comments,
as
noted for ia32. The same suggestions apply to the other architectures, which
have identical comments.
https://chromiumcodereview.appspot.com/9365020/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://chromiumcodereview.appspot.com/9365020/diff/1/src/arm/stub-cache-arm.cc#newcode1547
src/arm/stub-cache-arm.cc:1547: __ mov(r2, r1);
nit: s/r1/receiver/
https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia32.cc#newcode1365
src/ia32/stub-cache-ia32.cc:1365: // Get the element's length into ecx.
s/element's/elements'/
https://chromiumcodereview.appspot.com/9365020/diff/1/src/ia32/stub-cache-ia32.cc#newcode1379
src/ia32/stub-cache-ia32.cc:1379: // Push the element.
Maybe "Store the value"? or "Push the new element"? (cf. "Check if value
is a smi" above.)
https://chromiumcodereview.appspot.com/9365020/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://chromiumcodereview.appspot.com/9365020/diff/1/src/x64/stub-cache-x64.cc#newcode1366
src/x64/stub-cache-x64.cc:1366: rax, times_pointer_size,
nit: I'd align this under "rdi".
https://chromiumcodereview.appspot.com/9365020/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
