Reviewers: Yang,
Description:
Fix d8-os unit test to be skipped for isolates.
This test sets the umask on a per-process basis and hence cannot be
used in multi-threaded runs.
[email protected]
TEST=mjsunit/d8-os
Please review this at https://chromiumcodereview.appspot.com/9372018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/d8-os.js
M test/mjsunit/mjsunit.status
Index: test/mjsunit/d8-os.js
diff --git a/test/mjsunit/d8-os.js b/test/mjsunit/d8-os.js
index
d0d68a2d929ee7d263f57ce2a1980958eb917a36..239938cd169d73d3fb847cb7e30d0b767f4a2c9c
100644
--- a/test/mjsunit/d8-os.js
+++ b/test/mjsunit/d8-os.js
@@ -96,7 +96,9 @@ if (this.os && os.system) {
assertThrows("os.chdir(TEST_DIR + '/dir4');", "chdir dir4 I");
os.rmdir(TEST_DIR + "/dir4");
assertThrows("os.chdir(TEST_DIR + '/dir4');", "chdir dir4 II");
- // Set umask.
+
+ // Set umask. This changes the umask for the whole process and is
+ // the reason why the test cannot be run multi-threaded.
var old_umask = os.umask(0777);
// Create a dir we cannot read.
os.mkdirp(TEST_DIR + "/dir5");
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
186c2a465b1f9ac749e5c14cae43f71b518d5925..2d22fe9075063812e75315eb187eb823254d8451
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -66,6 +66,13 @@ debug-liveedit-check-stack: SKIP
debug-liveedit-patch-positions-replace: SKIP
##############################################################################
+[ $isolates ]
+
+# This test sets the umask on a per-process basis and hence cannot be
+# used in multi-threaded runs.
+d8-os: SKIP
+
+##############################################################################
[ $arch == arm ]
# Slow tests which times out in debug mode.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
