Revision: 10655
Author: [email protected]
Date: Thu Feb 9 01:52:38 2012
Log: Fix d8-os unit test to be skipped for isolates.
This test sets the umask on a per-process basis and hence cannot be
used in multi-threaded runs.
[email protected]
TEST=mjsunit/d8-os
Review URL: https://chromiumcodereview.appspot.com/9372018
http://code.google.com/p/v8/source/detail?r=10655
Modified:
/branches/bleeding_edge/test/mjsunit/d8-os.js
/branches/bleeding_edge/test/mjsunit/mjsunit.status
=======================================
--- /branches/bleeding_edge/test/mjsunit/d8-os.js Wed Feb 8 02:59:19 2012
+++ /branches/bleeding_edge/test/mjsunit/d8-os.js Thu Feb 9 01:52:38 2012
@@ -96,7 +96,9 @@
assertThrows("os.chdir(TEST_DIR + '/dir4');", "chdir dir4 I");
os.rmdir(TEST_DIR + "/dir4");
assertThrows("os.chdir(TEST_DIR + '/dir4');", "chdir dir4 II");
- // Set umask.
+
+ // Set umask. This changes the umask for the whole process and is
+ // the reason why the test cannot be run multi-threaded.
var old_umask = os.umask(0777);
// Create a dir we cannot read.
os.mkdirp(TEST_DIR + "/dir5");
=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Wed Feb 8 02:14:18
2012
+++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Thu Feb 9 01:52:38
2012
@@ -65,6 +65,13 @@
debug-liveedit-check-stack: SKIP
debug-liveedit-patch-positions-replace: SKIP
+##############################################################################
+[ $isolates ]
+
+# This test sets the umask on a per-process basis and hence cannot be
+# used in multi-threaded runs.
+d8-os: SKIP
+
##############################################################################
[ $arch == arm ]
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
