Comments addressed, landing.
https://chromiumcodereview.appspot.com/9361026/diff/3002/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://chromiumcodereview.appspot.com/9361026/diff/3002/src/arm/full-codegen-arm.cc#newcode144 src/arm/full-codegen-arm.cc:144: // for the SharedFunctionInfo::kCallsUntilPrimitiveOptimization-th time. On 2012/02/09 09:43:33, Erik Corry wrote:
I think this comment should be moved into ShouldSelfOptimize, where it
actually
describes the logic used to make the decision. Then it is in the
right place
for when we change the heuristic.
Here we should have a more generic comment like:
// We can optionally optimize based on counters rather than
statistical
sampling.
Done. https://chromiumcodereview.appspot.com/9361026/diff/3002/src/arm/full-codegen-arm.cc#newcode146 src/arm/full-codegen-arm.cc:146: if (FLAG_trace_opt) { On 2012/02/09 09:43:33, Erik Corry wrote:
I think this might be annoyingly verbose, but we can add a
trace-opt-verbose
flag later if we need to.
As discussed, let's leave it for now. We can always remove it later. https://chromiumcodereview.appspot.com/9361026/diff/3002/src/ic-inl.h File src/ic-inl.h (right): https://chromiumcodereview.appspot.com/9361026/diff/3002/src/ic-inl.h#newcode93 src/ic-inl.h:93: target); On 2012/02/09 09:43:33, Erik Corry wrote:
Confusing that this is under the counting_profiler flag when it
relates to the
statistically sampling profiler.
As discussed, I'll split the flag in a separate CL. https://chromiumcodereview.appspot.com/9361026/diff/3002/src/ic-inl.h#newcode94 src/ic-inl.h:94: if (FLAG_counting_profiler) { On 2012/02/09 09:43:33, Erik Corry wrote:
This function is getting too beefy for an inline function that is used
5 times.
I suggest this part be moved to a helper function in the .cc file.
Done. https://chromiumcodereview.appspot.com/9361026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
